From f1a92ba9fc6ad4e358295c7fe6ef5be472b28d7d Mon Sep 17 00:00:00 2001 From: Ingo Oeser Date: Sat, 22 Aug 2015 23:52:09 +0200 Subject: [PATCH] Checking via len is more robust because sometimes such APIs return nil slices, sometimes empty slices. We want nothing to happen in both cases. --- githook-gobuild/hook.go | 2 +- githook-gofmt/hook.go | 2 +- githook-gotest/hook.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/githook-gobuild/hook.go b/githook-gobuild/hook.go index 2545e7d..cdc52f3 100644 --- a/githook-gobuild/hook.go +++ b/githook-gobuild/hook.go @@ -9,7 +9,7 @@ import ( func main() { files := general.GetChangedGoFiles() - if files == nil { + if len(files) == 0 { os.Exit(0) return } diff --git a/githook-gofmt/hook.go b/githook-gofmt/hook.go index b29cfe6..d9e3fd2 100644 --- a/githook-gofmt/hook.go +++ b/githook-gofmt/hook.go @@ -10,7 +10,7 @@ import ( func main() { files := general.GetChangedGoFiles() - if files == nil { + if len(files) == 0 { os.Exit(0) return } diff --git a/githook-gotest/hook.go b/githook-gotest/hook.go index 99c683e..efca3ed 100644 --- a/githook-gotest/hook.go +++ b/githook-gotest/hook.go @@ -9,7 +9,7 @@ import ( func main() { files := general.GetChangedGoFiles() - if files == nil { + if len(files) == 0 { os.Exit(0) return }